Repository navigation
Reduce redundant toggle strings to stay within Crowdin limits - #2219
Merged
Merged
Conversation
Contributor
WalkthroughRemoved 16 state-specific translation keys from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
evanpelle
approved these changes
Oct 17, 2025
DevelopingTom
pushed a commit
to DevelopingTom/OpenFrontIO
that referenced
this pull request
Oct 24, 2025
…ontio#2219) ## Description: Purpose: to reduce redundant strings and avoid exceeding Crowdin’s text limit. - Replaced _enabled/_disabled text with shared ..._desc in SettingsModal.ts. <img width="432" height="645" alt="スクリーンショット 2025-10-17 21 38 47" src="https://github.com/user-attachments/assets/10942de4-1b2c-4df4-8811-95190463a2ab" /> ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: Aotumuri Co-authored-by: Evan <evanpelle@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Purpose: to reduce redundant strings and avoid exceeding Crowdin’s text limit.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
Aotumuri