Skip to content

Improve collapsed suggestions for trait impls tuples - #164156

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
rperier:fix_better_suggestions_for_trait_impls_tuples
Nov 16, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
rperier:fix_better_suggestions_for_trait_impls_tuples

Conversation

@rperier

@rperier rperier commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

View all comments

Fixes #163641

On my side the use cases contained in #163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 11, 2026
@rustbot

rustbot commented Oct 11, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, types
  • compiler, types expanded to 77 candidates
  • Random selection from 21 candidates

@rperier

rperier commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Otherwise I can test diesel-rs myself, np. What do I have to do ? only launch the tests ?

@rperier
rperier marked this pull request as draft October 12, 2026 16:36
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2026
@rperier
rperier force-pushed the fix_better_suggestions_for_trait_impls_tuples branch from c03716e to c4da207 Compare October 14, 2026 07:26
@rperier rperier changed the title WIP: Improve collapsed suggestions for trait impls tuples Improve collapsed suggestions for trait impls tuples Oct 14, 2026
@rperier
rperier marked this pull request as ready for review October 14, 2026 07:28
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2026
@rperier

rperier commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

@mejrs in case you're interested, as you reviewed the original feature.

@weiznich

Copy link
Copy Markdown
Contributor

Thanks for working on this ❤️

I did give this branch a try against diesel's compile tests and that are the changes compared to a nightly run from like 2 weeks ago. diesel-rs/diesel@94149ed

That means this likely includes changes not caused by this PR. You can still see that it works at least in one location: diesel-rs/diesel@94149ed#diff-b132b9a5ac7fd8f0b0c56b37497ffdde41c80139f1d4c4658fd7a52e2acdb52aR16-R17

diesel-rs/diesel@94149ed#diff-066d6de06c3ce8831c3761df40958cc6ab35dfdc514de934d46fd8a87248fd2eL301-R309 might be an interesting target for this as well. The tuple is a type argument there, not the type implementing the trait. I still think that would be another location to apply this kind of unification. (I'm unsure why it completely disappeared there, might be related to trait solver changes)

@rperier

rperier commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

Thanks for working on this ❤️

I did give this branch a try against diesel's compile tests and that are the changes compared to a nightly run from like 2 weeks ago. diesel-rs/diesel@94149ed

That means this likely includes changes not caused by this PR. You can still see that it works at least in one location: diesel-rs/diesel@94149ed#diff-b132b9a5ac7fd8f0b0c56b37497ffdde41c80139f1d4c4658fd7a52e2acdb52aR16-R17

diesel-rs/diesel@94149ed#diff-066d6de06c3ce8831c3761df40958cc6ab35dfdc514de934d46fd8a87248fd2eL301-R309 might be an interesting target for this as well. The tuple is a type argument there, not the type implementing the trait. I still think that would be another location to apply this kind of unification. (I'm unsure why it completely disappeared there, might be related to trait solver changes)

Mhhhh, interesting, thanks for the feedback ! I can trigger a build (+ tests) locally on my side with a stage1 compiler from my branch. It should be feasible . I can still compare my branch with and without the HEAD commit, and see the differences.

@weiznich

Copy link
Copy Markdown
Contributor

If you would like to run the diesel compile tests yourself you can will need the following steps:

  1. Install libpq-dev, libsqlite3-dev and libmysqlclient-dev
  2. Clone the diesel repo from https://github.com/diesel-rs/diesel
  3. Change to the diesel_compile_tests folder
  4. Run cargo test there
    (5. Accept changes by setting BLESS=1 as environment variable)

@rperier

rperier commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor Author

If you would like to run the diesel compile tests yourself you can will need the following steps:

1. Install libpq-dev, libsqlite3-dev and libmysqlclient-dev

2. Clone the diesel repo from https://github.com/diesel-rs/diesel

3. Change to the diesel_compile_tests folder

4. Run cargo test there
   (5. Accept changes by setting `BLESS=1` as environment variable)

Thanks for the details ! On my side, I have tested diesel in the diesel_compile_tests folder, I have found that the last official working compiler version is 1.99.0 (1.99.1 is not working). So have done the following:

  1. I have built a stage 2 compiler from the tag 1.99.0 in the rust repo
  2. I launched cargo +stage2 test from the diesel_compile_tests folder, I only had few difference compared to the official rustc 1.99.0 that is shipped with rustup (nothing very important), I have blessed all these diff
  3. Then I have backported my changes for the new version of the collapsed suggestions for trait impls tuples onto 1.99.0 and I have rebuilt a stage 2 compiler from there
  4. I have reran the test using cargo +stage2 test to see the difference, the difference is just here: rperier/diesel@28b2f87

Then, I have searched over the remaining tests in tests/fails in order to analyze the output of the non collapsed outputs, either these are not continious by step of 1 or these do not implement the same trait.

that sounds good.

@rperier

rperier commented Oct 25, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot reroll

@rustbot rustbot assigned jackh726 and unassigned TaKO8Ki Oct 25, 2026

@teor2345 teor2345 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick review of the diagnostic wording

View changes since this review

@rperier
rperier force-pushed the fix_better_suggestions_for_trait_impls_tuples branch from c4da207 to e1ea606 Compare November 6, 2026 15:33
@rustbot

This comment has been minimized.

Currently this collapsed output only works when all the candidates
implement the same trait and are continious over their arity by step of 1.
Sometimes we might find candidates that do not all implement the same trait but
which contains subsets of continious tuples all implementing the same trait.
@rperier
rperier force-pushed the fix_better_suggestions_for_trait_impls_tuples branch from e1ea606 to 8b24bbd Compare November 14, 2026 15:02
@rustbot

rustbot commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rperier

rperier commented Nov 14, 2026

Copy link
Copy Markdown
Contributor Author

I have fixed what you suggested. I have simplified the code to get rid of indices. The code should be more idiomatic, we still rely on ranges because we use Vec::splice(). I have also added comments.

let mut last_tuple_trait_ref = None;

fn have_same_trait_path(a: &TraitRef<'_>, b: &TraitRef<'_>) -> bool {
a.print_only_trait_path().to_string() == b.print_only_trait_path().to_string()

@estebank estebank Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not ideal, but lets roll with it for now. It'd be better to compare the DefId and args of the trait itself.

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can fix it in another PR, if you want.

@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8b24bbd has been approved by estebank

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 24 pull requests

Successful merges:

 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #166011 (Clean revert of recent `String::retain` changes)
 - #159805 (Implemented different with_native_path conversion methods, refactoring fs functions to utilize with_native_path, and move exists to use with_native_path)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165979 (Improve index inference diagnostics)
 - #165983 (Update `minifier-rs` dependency version to `0.5.0`)
 - #165999 (Update TPDE submodule)
 - #166005 (add ABI compat checks for new float types)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165993 (pipe_subprocess test: use libtest harness)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
 - #165998 (Cleanup borrowck)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 16, 2026
…_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes rust-lang#163641

On my side the use cases contained in rust-lang#163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #166039 (`rust-analyzer` subtree update)
 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #166039 (`rust-analyzer` subtree update)
 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #166039 (`rust-analyzer` subtree update)
 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
@rust-bors
rust-bors Bot merged commit c2c0613 into rust-lang:main Nov 16, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
Rollup merge of #164156 - rperier:fix_better_suggestions_for_trait_impls_tuples, r=estebank

Improve collapsed suggestions for trait impls tuples

Fixes #163641

On my side the use cases contained in #163641 work. Most of the examples in diesel shown in diesel-rs/diesel#5260 should work too.

No LLM, entirely written and tested by myself.
sushink70 pushed a commit to sushink70/miri that referenced this pull request Nov 17, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#166039 (`rust-analyzer` subtree update)
 - rust-lang/rust#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang/rust#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang/rust#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang/rust#163891 (Do not include context span when source is unavailable to render)
 - rust-lang/rust#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang/rust#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang/rust#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang/rust#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang/rust#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang/rust#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang/rust#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang/rust#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang/rust#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang/rust#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang/rust#165956 (Document wide pointers in core::ptr module)
 - rust-lang/rust#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang/rust#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 17, 2026
…nathanBrouwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang#166039 (`rust-analyzer` subtree update)
 - rust-lang#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang#163891 (Do not include context span when source is unavailable to render)
 - rust-lang#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang#165956 (Document wide pointers in core::ptr module)
 - rust-lang#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Nov 17, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#166039 (`rust-analyzer` subtree update)
 - rust-lang/rust#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang/rust#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang/rust#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang/rust#163891 (Do not include context span when source is unavailable to render)
 - rust-lang/rust#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang/rust#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang/rust#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang/rust#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang/rust#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang/rust#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang/rust#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang/rust#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang/rust#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang/rust#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang/rust#165956 (Document wide pointers in core::ptr module)
 - rust-lang/rust#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang/rust#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Nov 17, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#166039 (`rust-analyzer` subtree update)
 - rust-lang/rust#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang/rust#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang/rust#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang/rust#163891 (Do not include context span when source is unavailable to render)
 - rust-lang/rust#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang/rust#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang/rust#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang/rust#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang/rust#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang/rust#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang/rust#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang/rust#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang/rust#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang/rust#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang/rust#165956 (Document wide pointers in core::ptr module)
 - rust-lang/rust#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang/rust#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improved diagnostic for tuple impl's doesn't always work

7 participants