Skip to content

Fix panic on non-UTF-8 command-line arguments when RUST_BACKTRACE is unset - #165987

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
TaKO8Ki:ice-hook-non-utf8-args
Nov 16, 2026
Merged

rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
TaKO8Ki:ice-hook-non-utf8-args

Conversation

@TaKO8Ki

@TaKO8Ki TaKO8Ki commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Fixes #164585

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 15, 2026
@rustbot

rustbot commented Nov 15, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 79 candidates
  • Random selection from 20 candidates

@rust-log-analyzer

This comment has been minimized.

@TaKO8Ki
TaKO8Ki force-pushed the ice-hook-non-utf8-args branch from 76416d6 to 2e2053d Compare November 15, 2026 02:18
@TaKO8Ki
TaKO8Ki force-pushed the ice-hook-non-utf8-args branch from 2e2053d to 84661ca Compare November 15, 2026 02:19
@workingjubilee

Copy link
Copy Markdown
Member

Very silly.

Thank you.

@bors r+ rollup

@rust-bors

rust-bors Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 84661ca has been tentatively approved by workingjubilee

It will be put into the queue for this repository once PR CI succeeds.

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

Reason for tree closure: consistent failures on main

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 15, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 24 pull requests

Successful merges:

 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #166011 (Clean revert of recent `String::retain` changes)
 - #159805 (Implemented different with_native_path conversion methods, refactoring fs functions to utilize with_native_path, and move exists to use with_native_path)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165979 (Improve index inference diagnostics)
 - #165983 (Update `minifier-rs` dependency version to `0.5.0`)
 - #165999 (Update TPDE submodule)
 - #166005 (add ABI compat checks for new float types)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165993 (pipe_subprocess test: use libtest harness)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
 - #165998 (Cleanup borrowck)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 16, 2026
…workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes rust-lang#164585
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #166039 (`rust-analyzer` subtree update)
 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #166039 (`rust-analyzer` subtree update)
 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - #166039 (`rust-analyzer` subtree update)
 - #165819 (Avoid redundant scans when extracting stage0 archives)
 - #157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - #162414 (Make min/max and copysign intrinsics generic)
 - #163891 (Do not include context span when source is unavailable to render)
 - #164156 (Improve collapsed suggestions for trait impls tuples)
 - #165900 ([tiny] Tweak wording of missing `core` note)
 - #165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - #165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - #165792 (prevent optimization for input in ascii benchmarks)
 - #165936 (Enhance documentation for try_clone File implementation)
 - #165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - #165941 (Merge `type_bf16()` with `type_f16b()`)
 - #165942 (windows: use io::const_error in get_access_mode)
 - #165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - #165956 (Document wide pointers in core::ptr module)
 - #165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - #165996 (Fix(docs): Correct discard behavior in datagram peek docs)
@rust-bors
rust-bors Bot merged commit b7d60ad into rust-lang:main Nov 16, 2026
14 checks passed
@rustbot rustbot added this to the 1.102.0 milestone Nov 16, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 16, 2026
Rollup merge of #165987 - TaKO8Ki:ice-hook-non-utf8-args, r=workingjubilee

Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset

Fixes #164585
sushink70 pushed a commit to sushink70/miri that referenced this pull request Nov 17, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#166039 (`rust-analyzer` subtree update)
 - rust-lang/rust#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang/rust#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang/rust#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang/rust#163891 (Do not include context span when source is unavailable to render)
 - rust-lang/rust#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang/rust#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang/rust#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang/rust#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang/rust#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang/rust#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang/rust#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang/rust#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang/rust#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang/rust#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang/rust#165956 (Document wide pointers in core::ptr module)
 - rust-lang/rust#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang/rust#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
flip1995 pushed a commit to flip1995/rust that referenced this pull request Nov 17, 2026
…nathanBrouwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang#166039 (`rust-analyzer` subtree update)
 - rust-lang#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang#163891 (Do not include context span when source is unavailable to render)
 - rust-lang#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang#165956 (Document wide pointers in core::ptr module)
 - rust-lang#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Nov 17, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#166039 (`rust-analyzer` subtree update)
 - rust-lang/rust#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang/rust#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang/rust#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang/rust#163891 (Do not include context span when source is unavailable to render)
 - rust-lang/rust#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang/rust#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang/rust#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang/rust#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang/rust#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang/rust#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang/rust#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang/rust#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang/rust#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang/rust#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang/rust#165956 (Document wide pointers in core::ptr module)
 - rust-lang/rust#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang/rust#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
bjorn3 pushed a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request Nov 17, 2026
…uwer

Rollup of 18 pull requests

Successful merges:

 - rust-lang/rust#166039 (`rust-analyzer` subtree update)
 - rust-lang/rust#165819 (Avoid redundant scans when extracting stage0 archives)
 - rust-lang/rust#157984 (-Zassumptions-on-binders: Emit new-style region constraints from type relations)
 - rust-lang/rust#162414 (Make min/max and copysign intrinsics generic)
 - rust-lang/rust#163891 (Do not include context span when source is unavailable to render)
 - rust-lang/rust#164156 (Improve collapsed suggestions for trait impls tuples)
 - rust-lang/rust#165900 ([tiny] Tweak wording of missing `core` note)
 - rust-lang/rust#165978 (Mention `#![doc = include_str!(...)]` trick in intro page)
 - rust-lang/rust#165406 (Do not suggest `as_deref` for a slice pattern on `Err`)
 - rust-lang/rust#165792 (prevent optimization for input in ascii benchmarks)
 - rust-lang/rust#165936 (Enhance documentation for try_clone File implementation)
 - rust-lang/rust#165938 (`rustc_hir_typeck::upvar`: replace for loop with `.any()`)
 - rust-lang/rust#165941 (Merge `type_bf16()` with `type_f16b()`)
 - rust-lang/rust#165942 (windows: use io::const_error in get_access_mode)
 - rust-lang/rust#165946 (PassWrapper: adapt for latest round of LLVM codegen flag refactor)
 - rust-lang/rust#165956 (Document wide pointers in core::ptr module)
 - rust-lang/rust#165987 (Fix panic on non-UTF-8 command-line arguments when `RUST_BACKTRACE` is unset)
 - rust-lang/rust#165996 (Fix(docs): Correct discard behavior in datagram peek docs)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rustc can't handle non-UTF-8 input paths, but only when RUST_BACKTRACE is not set

5 participants