Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
view-types/check-field-access
branch
2 times, most recently
from
November 12, 2026 08:56
3a6417a to
b489285
Compare
This comment has been minimized.
This comment has been minimized.
scrabsha
force-pushed
the
view-types/check-field-access
branch
2 times, most recently
from
November 12, 2026 15:04
73cdfb4 to
7d7b53b
Compare
scrabsha
force-pushed
the
view-types/check-field-access
branch
2 times, most recently
from
November 13, 2026 22:12
936e861 to
ddf89da
Compare
scrabsha
commented
Nov 14, 2026
scrabsha
commented
Nov 16, 2026
This comment has been minimized.
This comment has been minimized.
/!\ the test suite is has not been updated /!\
scrabsha
force-pushed
the
view-types/check-field-access
branch
from
November 19, 2026 15:16
ddf89da to
211c9dd
Compare
Contributor
Author
|
force push contains:
|
This comment has been minimized.
This comment has been minimized.
/!\ the #legal revision of field-access.rs has not been updated /!\
/!\ the test suite is has not been updated /!\ the ICE we are currently fixing uses the debug print of view types, which was `unimplemented!()`, which triggered another ICE. this commit adds an implementation of `Debug` for `ty::View`, which gives us a much more interesting backtrace (which is fixed by the next commit).
/!\ the #legal revision still triggers an ICE, but a new one this time :fire: /!\
scrabsha
force-pushed
the
view-types/check-field-access
branch
from
November 19, 2026 15:26
211c9dd to
1375823
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the main idea of this commit is to handle the following code:
this plugs quite nicely in the deref step checking, allowing for access to
fooon types like&&&&&view_type(MyStruct.{ foo })as well as types that deref to reference to&view_type!(...)1. tuple structs are also supported.the first three commits are an attempt to refactor of
FnCtxt::check_expr_field. it was quite overwhelming for me to understand how this function works so i figured i could try to make the it easier for the next person that has to look at it. i kept the refactoring split in three commits because i think it eases review (the ui test suite passes for all three commit), but i'm happy to squash them into one, or drop them entirely.r? oli-obk
over #165694.
@rustbot blocked by #165694.
Note
Footnotes
The reference is needed here because view types are
!MetaSized, which does not satisfies the!Sizedbound onDeref::Target. ↩