Skip to content

Rollup of 15 pull requests - #166141

Merged
rust-bors[bot] merged 47 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ZQcXVqU
Nov 18, 2026
Merged

rust-bors[bot] merged 47 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-ZQcXVqU

Conversation

@JonathanBrouwer

Copy link
Copy Markdown
Member

Successful merges:

Failed merges:

r? @ghost

Create a similar rollup

beetrees and others added 30 commits November 12, 2026 16:52
Since the translation effort has stopped, we don't need to support list formatting in other languages at the moment. This allows removing multiple dependencies entirely and removes the last usage of `rustc_baked_icu_data`.
We will now give users two options, to go with the traditional coroutine
layout as of Dec 2025 or the new proposed compact layout.

The compact layout will be documented in the RelocateUpvar MIR pass
later.

Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>

Signed-off-by: Xiangfei Ding <dingxiangfei2009@protonmail.ch>
…tool_lint!`

And make it follow style of the other boolean `@eval_always = true`.

More cleanups can be made, but we keep the diff minimal.
When failing to find a field after a method call, look for other methods with the same name on the receiver that are shadowed and have a return type that has the field name we couldn't find:

```
error[E0609]: no field `next` on type `&mut Rc<RefCell<Node>>`
    --> tests/ui/methods/method-shadowed-by-trait.rs:41:53
     |
  41 |             Some(old_tail) => old_tail.borrow_mut().next = Some(node.clone()),
     |                                        ----------   ^^^^ unknown field
     |                                        |
     |                                        this method is `std::borrow::BorrowMut::borrow_mut`
     |
note: this returns `&mut Rc<RefCell<Node>>`
    --> library/core/src/borrow.rs:207:5
     |
 190 | pub const trait BorrowMut<Borrowed: ?Sized>: [const] Borrow<Borrowed> {
...
 207 |     fn borrow_mut(&mut self) -> &mut Borrowed;
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: you might have meant to call `std::cell::RefCell::<T>::borrow_mut` instead
    --> library/core/src/cell.rs:1226:5
     |
1089 | impl<T: ?Sized> RefCell<T> {
...
1226 |     pub const fn borrow_mut(&self) -> RefMut<'_, T> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider calling `std::cell::RefCell::<T>::borrow_mut` using the fully-qualified path
     |
  41 -             Some(old_tail) => old_tail.borrow_mut().next = Some(node.clone()),
  41 +             Some(old_tail) => RefCell::borrow_mut(&old_tail).next = Some(node.clone()),
     |
```
…hain

When failing to find a method after another method call, look for other methods with the same name on the receiver that are shadowed and have a return type that has the method we couldn't find:

```
error[E0599]: no method named `method` found for unit type `()` in the current scope
  --> $DIR/method-shadowed-by-trait.rs:104:13
   |
LL |     x.foo().method();
   |       ---   ^^^^^^ method not found in `()`
   |       |
   |       this method is `a::T::foo`
   |
note: this returns `()`
  --> $DIR/method-shadowed-by-trait.rs:71:9
   |
LL |     pub trait T {
LL |         fn foo(&self) {}
   |         ^^^^^^^^^^^^^
note: you might have meant to call `a::K::foo` instead
  --> $DIR/method-shadowed-by-trait.rs:78:9
   |
LL |     pub trait K {
LL |         fn foo(&self) -> Other { Other { field : () } }
   |         ^^^^^^^^^^^^^^^^^^^^^^
note: you might have meant to call `a::V::foo` instead
  --> $DIR/method-shadowed-by-trait.rs:85:9
   |
LL |     pub trait V {
LL |         fn foo(&self) -> Other;
   |         ^^^^^^^^^^^^^^^^^^^^^^^
note: you might have meant to call `S::foo` instead
  --> $DIR/method-shadowed-by-trait.rs:64:5
   |
LL | impl S {
LL |     fn foo(&self) -> Other { Other { field: () } }
   |     ^^^^^^^^^^^^^^^^^^^^^^
help: consider calling `a::K::foo` using the fully-qualified path
   |
LL -     x.foo().method();
LL +     <_ as K>::foo(&x).method();
   |
help: consider calling `a::V::foo` using the fully-qualified path
   |
LL -     x.foo().method();
LL +     <_ as V>::foo(&x).method();
   |
help: consider calling `S::foo` using the fully-qualified path
   |
LL -     x.foo().method();
LL +     S::foo(&x).method();
   |
```
```
error[E0599]: no method named `method` found for unit type `()` in the current scope
  --> $DIR/method-shadowed-by-trait.rs:120:15
   |
LL |     let y = x.foo();
   |               --- this method is `a::T::foo`
...
LL |     let _ = y.method();
   |               ^^^^^^ method not found in `()`
   |
note: this returns `()`
  --> $DIR/method-shadowed-by-trait.rs:73:9
   |
LL |     pub trait T {
LL |         fn foo(&self) {}
   |         ^^^^^^^^^^^^^
note: you might have meant to call `a::K::foo` instead
  --> $DIR/method-shadowed-by-trait.rs:82:9
   |
LL |     pub trait K {
LL |         fn foo(&self) -> Other { Other { field : () } }
   |         ^^^^^^^^^^^^^^^^^^^^^^
```
```
error[E0369]: binary operation `>` cannot be applied to type `std::sync::MutexGuard<'_, RefCell<i32>>`
    --> tests/ui/methods/method-shadowed-by-trait-in-binop.rs:20:29
     |
  13 |         let opt_target = cell.borrow();
     |                               ------ this method is `std::borrow::Borrow::borrow`
...
  20 |         let _ = *opt_target > 1; //~ ERROR: binary operation `>` cannot be applied
     |                 ----------- ^ - {integer}
     |                 |
     |                 std::sync::MutexGuard<'_, RefCell<i32>>
     |
note: `std::sync::MutexGuard<'_, RefCell<i32>>` does not implement `PartialOrd<{integer}>`
    --> library/std/src/sync/poison/mutex.rs:277:1
     |
 277 | / pub struct MutexGuard<
 278 | |     #[rustc_assert_variance(covariant)] 'a,
 279 | |     #[rustc_assert_variance(invariant)] T: ?Sized + 'a,
 280 | | > {
     | |_^ `std::sync::MutexGuard<'_, RefCell<i32>>` is defined in another crate
note: this returns `std::sync::MutexGuard<'_, RefCell<i32>>`
    --> library/core/src/borrow.rs:179:5
     |
 158 | pub const trait Borrow<Borrowed: ?Sized> {
...
 179 |     fn borrow(&self) -> &Borrowed;
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: you might have meant to call `std::cell::RefCell::<T>::borrow` instead
    --> library/core/src/cell.rs:1126:5
     |
1089 | impl<T: ?Sized> RefCell<T> {
...
1126 |     pub const fn borrow(&self) -> Ref<'_, T> {
     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
help: consider calling `std::cell::RefCell::<T>::borrow` using the fully-qualified path
     |
  13 -         let opt_target = cell.borrow();
  13 +         let opt_target = RefCell::borrow(&cell);
     |
```
…tainer

Signed-off-by: Amaan Qureshi <git@amaanq.com>
Change-Id: I72724d9eb58146bd86c0b47770af5bcb6a6a6964
Let's link the relevant UI tests to the Reference's rules for inline
assembly.
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,dist-various-2,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3,test-aarch64-msvc-2

@rust-bors

rust-bors Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

📌 Commit abceb21 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2026
rust-bors Bot pushed a commit that referenced this pull request Nov 18, 2026
Rollup of 15 pull requests


try-job: dist-various-1
try-job: dist-various-2
try-job: test-various
try-job: test-x86_64-gnu-aux
try-job: test-x86_64-msvc-1
try-job: test-aarch64-apple-1
try-job: test-aarch64-apple-2
try-job: test-x86_64-mingw-1
try-job: test-i686-msvc
try-job: test-armhf-gnu
try-job: test-x86_64-gnu-llvm-22-3
try-job: test-aarch64-msvc-2
@rust-bors

This comment has been minimized.

@rust-bors

rust-bors Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 2a8211c (2a8211cd83cc3c1ae88835a56146deae069f1d9e)
Base parent: 6c587fd (6c587fd5a7f62ceb4fda4e19f0af26d2f9521ae6)

@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2026
@rust-bors

rust-bors Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 28m 42s
Pushing 412be32 to main...

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6c587fd (parent) -> 412be32 (this PR)

Test differences

Show 112 test diffs

Stage 1

  • [ui (polonius)] tests/ui/abi/bad-custom.rs: pass -> [missing] (J0)
  • [ui (polonius)] tests/ui/abi/bad-custom.rs#edition2015: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/abi/bad-custom.rs#edition2018: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/borrowck/const-cannot-move-shared-ref.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/c-variadic/obligation-span.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/coroutine/pack-coroutine-layout-flag.rs#captures_only: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/coroutine/pack-coroutine-layout-flag.rs#classic: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/coroutine/pack-coroutine-layout-flag.rs#invalid: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/methods/method-shadowed-by-trait-in-binop.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/methods/method-shadowed-by-trait.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/methods/similar-method-out-of-scope-trait.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/pattern/rfc-3637-guard-patterns/borrow-check.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/pattern/rfc-3637-guard-patterns/closure.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/privacy/privacy-in-params.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/tool-attributes/register_reflected_tool.rs: [missing] -> pass (J0)
  • [ui (polonius)] tests/ui/trait-bounds/wf-check-c-variadics.rs: [missing] -> pass (J0)
  • [assembly] tests/assembly-llvm/c-variadic/m68k.rs: [missing] -> pass (J1)
  • [ui] tests/ui/abi/bad-custom.rs: pass -> [missing] (J3)
  • [ui] tests/ui/abi/bad-custom.rs#edition2015: [missing] -> pass (J3)
  • [ui] tests/ui/abi/bad-custom.rs#edition2018: [missing] -> pass (J3)
  • [ui] tests/ui/borrowck/const-cannot-move-shared-ref.rs: [missing] -> pass (J3)
  • [ui] tests/ui/c-variadic/obligation-span.rs: [missing] -> pass (J3)
  • [ui] tests/ui/coroutine/pack-coroutine-layout-flag.rs#captures_only: [missing] -> pass (J3)
  • [ui] tests/ui/coroutine/pack-coroutine-layout-flag.rs#classic: [missing] -> pass (J3)
  • [ui] tests/ui/coroutine/pack-coroutine-layout-flag.rs#invalid: [missing] -> pass (J3)
  • [ui] tests/ui/methods/method-shadowed-by-trait-in-binop.rs: [missing] -> pass (J3)
  • [ui] tests/ui/methods/method-shadowed-by-trait.rs: [missing] -> pass (J3)
  • [ui] tests/ui/methods/similar-method-out-of-scope-trait.rs: [missing] -> pass (J3)
  • [ui] tests/ui/pattern/rfc-3637-guard-patterns/borrow-check.rs: [missing] -> pass (J3)
  • [ui] tests/ui/pattern/rfc-3637-guard-patterns/closure.rs: [missing] -> pass (J3)
  • [ui] tests/ui/privacy/privacy-in-params.rs: [missing] -> pass (J3)
  • [ui] tests/ui/tool-attributes/register_reflected_tool.rs: [missing] -> pass (J3)
  • [ui] tests/ui/trait-bounds/wf-check-c-variadics.rs: [missing] -> pass (J3)

Stage 2

  • [ui] tests/ui/abi/bad-custom.rs: pass -> [missing] (J2)
  • [ui] tests/ui/abi/bad-custom.rs#edition2015: [missing] -> pass (J2)
  • [ui] tests/ui/abi/bad-custom.rs#edition2018: [missing] -> pass (J2)
  • [ui] tests/ui/borrowck/const-cannot-move-shared-ref.rs: [missing] -> pass (J2)
  • [ui] tests/ui/c-variadic/obligation-span.rs: [missing] -> pass (J2)
  • [ui] tests/ui/coroutine/pack-coroutine-layout-flag.rs#captures_only: [missing] -> pass (J2)
  • [ui] tests/ui/coroutine/pack-coroutine-layout-flag.rs#classic: [missing] -> pass (J2)
  • [ui] tests/ui/coroutine/pack-coroutine-layout-flag.rs#invalid: [missing] -> pass (J2)
  • [ui] tests/ui/methods/method-shadowed-by-trait-in-binop.rs: [missing] -> pass (J2)
  • [ui] tests/ui/methods/method-shadowed-by-trait.rs: [missing] -> pass (J2)
  • [ui] tests/ui/methods/similar-method-out-of-scope-trait.rs: [missing] -> pass (J2)
  • [ui] tests/ui/pattern/rfc-3637-guard-patterns/borrow-check.rs: [missing] -> pass (J2)
  • [ui] tests/ui/pattern/rfc-3637-guard-patterns/closure.rs: [missing] -> pass (J2)
  • [ui] tests/ui/privacy/privacy-in-params.rs: [missing] -> pass (J2)
  • [ui] tests/ui/tool-attributes/register_reflected_tool.rs: [missing] -> pass (J2)
  • [ui] tests/ui/trait-bounds/wf-check-c-variadics.rs: [missing] -> pass (J2)
  • [assembly] tests/assembly-llvm/c-variadic/m68k.rs: [missing] -> pass (J4)

Additionally, 62 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 412be32a6a189d9a28922beee178bc0abee9d492 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. test-x86_64-gnu-llvm-22-2: 1h 5m -> 1h 44m (+60.5%)
  2. test-x86_64-gnu-gcc-core-tests: 9m 57s -> 14m 32s (+46.1%)
  3. test-i686-gnu-nopt-2: 1h 39m -> 2h 24m (+44.9%)
  4. test-x86_64-gnu-stdlib-semver-check: 9m 48s -> 13m 53s (+41.7%)
  5. test-x86_64-gnu-miri: 48m 17s -> 1h 8m (+41.1%)
  6. test-pr-check-1: 21m 3s -> 28m 54s (+37.3%)
  7. test-x86_64-msvc-ext1: 1h 43m -> 2h 21m (+37.1%)
  8. test-x86_64-gnu-debug: 1h 34m -> 2h 9m (+36.7%)
  9. test-x86_64-gnu-stable: 2h 32m -> 1h 37m (-36.3%)
  10. test-armhf-gnu: 1h 9m -> 1h 34m (+35.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (412be32): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.4%, -0.0%] 6
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.2%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.2% [1.2%, 1.2%] 1
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.2% [1.2%, 1.2%] 1

Cycles

Results (primary 2.5%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.5% [2.5%, 2.5%] 1
Regressions ❌
(secondary)
1.2% [0.6%, 2.5%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.5% [2.5%, 2.5%] 1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 464.835s -> 458.383s (-1.39%)
Artifact size: 405.36 MiB -> 405.23 MiB (-0.03%)

@rust-bors

rust-bors Bot commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#166037 reflection: enable tool attributes to be reflectable c122d6e0344608d79ae25ee1caddee077f8a677c
(link)
#165465 Use emit_ptr_va_arg for va_arg on M68k 6d5902f38669ac92e99dee30cde6b3f986f7222f
(link)
#166042 Fix out of scope method suggestion e223963c75d9bd1ea4b30c4009b3875e8f737db4
(link)
#166090 bootstrap: rebuild LLD when LLVM changes 752179222c9b98cbc235b354f4ff41b34c31dd15
(link)
#159795 Introduce -Z pack-coroutine-layout flag 572aca1c35e59ff726fdbb5ad9c5433e2fa82570
(link)
#163556 arm: only f32 and f64 are valid HFA bases 5aec28505d458a55b8f30221402df85b8cf96e3e
(link)
#164665 Add Reference annotations for inline assembly 33979e82e5fb00b7f282355f06aa5d7e0668875f
(link)
#165725 change target modifier errors to use the diagnostic APIs in… 9f37d2228ef6c94281c824639004b09234c3ddc0
(link)
#165912 simplify fluent_value_from_str_list_sep_by_and f27624c07e40762f1f39bef35ea7461cd33cba5e
(link)
#165982 compiler: Stop special-casing report_in_external_macro in… fffcdffdd7e6df9c229e66a6ca8a21e471767adf
(link)
#166006 Detect method shadowed by another when accessing a field or… d521bfbebd91573f78fe6d78a4a2d6ec6bd89db2
(link)
#166083 Record seeds in the appropriate order 68f3e2068caa9b267e7692b30944c181c54a22b4
(link)
#166104 abi/bad-custom.rs: make test run on all editions 756f62e7b10ced0158cb210d00a9f1d1fcc475bb
(link)
#166124 platform-support: add amaanq as powerpc64-unknown-linux-gnu… 5d64fd21810ad6ab32cd5ae55e19531c285add69
(link)
#166127 Add tests from failed attempt at implementing hir::Param … 153e432382f440f0e7a7f7414acf2addddedcd56
(link)

parent commit: 6c587fd5a7

In the case of a perf regression, run the following command with the SHAs of each PR you suspect might be the cause: @rust-timer triage $SHA $SHA $SHA..., or run @rust-timer triage all to benchmark all rollup members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-json Area: Rustdoc JSON backend A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.