Skip to content

Use correct name for undefined linked toolchain invocation - #1008

Merged
brson merged 1 commit into
rust-lang:masterfrom
topecongiro:undefined-linked-toolchain
Mar 31, 2017
Merged

brson merged 1 commit into
rust-lang:masterfrom
topecongiro:undefined-linked-toolchain

Conversation

@topecongiro

Copy link
Copy Markdown
Contributor

Closes #927.

@brson

brson commented Mar 23, 2017 •

Copy link
Copy Markdown
Contributor

Thanks @topecongiro!

Can you add a test to cli-exact.rs that captures the output of of cargo +bogus test after this? You should be able to crib off the existing cases in that file.

@topecongiro

Copy link
Copy Markdown
Contributor Author

@brson I will try and rebase. Thank you!

@topecongiro
topecongiro force-pushed the undefined-linked-toolchain branch from 28c7382 to ded5ee2 Compare March 24, 2017 00:52
@brson

brson commented Mar 27, 2017

Copy link
Copy Markdown
Contributor

@bors r+ Thanks @topecongiro !

@bors

bors commented Mar 27, 2017

Copy link
Copy Markdown
Contributor

📌 Commit ded5ee2 has been approved by brson

@bors

bors commented Mar 27, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit ded5ee2 with merge 3b8ad1e...

bors added a commit that referenced this pull request Mar 27, 2017
Use correct name for undefined linked toolchain invocation

Closes #927.
@bors

bors commented Mar 27, 2017

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@brson

brson commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Interesting failure here @topecongiro on windows. It looks to me like it's failing because on windows rustup is emitting a "info: found 0 remaining processes" .... which is bizarre. I think you should just delete that info! line from job.rs to make all platforms agree.

@topecongiro
topecongiro force-pushed the undefined-linked-toolchain branch from ded5ee2 to 645f2d9 Compare March 28, 2017 06:59
@topecongiro

Copy link
Copy Markdown
Contributor Author

@brson Thank you for pointing out! Rebased.

@brson

brson commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

📌 Commit 645f2d9 has been approved by brson

@bors

bors commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit 645f2d9 with merge 3b0337c...

bors added a commit that referenced this pull request Mar 28, 2017
Use correct name for undefined linked toolchain invocation

Closes #927.
@bors

bors commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@brson

brson commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@bors

bors commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

📌 Commit 645f2d9 has been approved by brson

@brson

brson commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Aggressive remove_dir_all #1015

@bors

bors commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

📌 Commit 645f2d9 has been approved by brson

@brson
brson merged commit c18094e into rust-lang:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants