Skip to content

Aggressive remove_dir_all - #1015

Merged
brson merged 3 commits into
rust-lang:masterfrom
brson:remove_dir_all
Apr 5, 2017
Merged

brson merged 3 commits into
rust-lang:masterfrom
brson:remove_dir_all

Conversation

@brson

@brson brson commented Mar 28, 2017

Copy link
Copy Markdown
Contributor

Let's see if this helps the flakiness.

cc @Diggsey @alexcrichton

cc @Aaronepower this PR contains a self-contained remove_dir_all module based on winapi.

@Diggsey

Diggsey commented Mar 29, 2017 •

Copy link
Copy Markdown
Contributor

Looks like we might need an aggressive remove_file too...

@alexcrichton

Copy link
Copy Markdown
Member

I personally forget, but can you clarify how precisely this is more aggressive again?

@Diggsey

Diggsey commented Mar 29, 2017

Copy link
Copy Markdown
Contributor

It moves the files out of the subdirectory and up next to the directory being deleted, prior to deleting them. This means if the file deletion is delayed due to outstanding locks, then the directories can still be deleted successfully without waiting for other processes to close their file handles.

The failure here looks different - like a race condition in one of the self-updater tests possibly?

@brson

brson commented Mar 29, 2017

Copy link
Copy Markdown
Contributor Author

Updated to fix the linux build hopefully.

@brson

brson commented Mar 31, 2017

Copy link
Copy Markdown
Contributor Author

@bors r+

@bors

bors commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

📌 Commit b61370a has been approved by brson

@bors

bors commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

⌛ Testing commit b61370a with merge 0acd9dd...

bors added a commit that referenced this pull request Mar 31, 2017
Aggressive remove_dir_all

Let's see if this helps the flakiness.

cc @Diggsey @alexcrichton

cc @Aaronepower this PR contains a self-contained remove_dir_all module based on winapi.
@bors

bors commented Mar 31, 2017

Copy link
Copy Markdown
Contributor

💔 Test failed - status-appveyor

@brson
brson merged commit 605bb99 into rust-lang:master Apr 5, 2017
@brson

brson commented Apr 5, 2017

Copy link
Copy Markdown
Contributor Author

Test failure was network error and i want to deploy this in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants