Repository navigation
feat(cli): add dynamic completions for rustup target add - #5110
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
14elias
force-pushed
the
feat/target-add-completion
branch
3 times, most recently
from
September 28, 2026 18:36
84e5ffc to
dc1c308
Compare
This comment has been minimized.
This comment has been minimized.
djc
reviewed
Sep 29, 2026
rami3l
requested changes
Sep 29, 2026
14elias
force-pushed
the
feat/target-add-completion
branch
from
October 1, 2026 16:14
dc1c308 to
425dffd
Compare
This comment has been minimized.
This comment has been minimized.
djc
reviewed
Oct 1, 2026
14elias
force-pushed
the
feat/target-add-completion
branch
2 times, most recently
from
October 2, 2026 14:51
60a1b08 to
4b30f27
Compare
rami3l
reviewed
Oct 2, 2026
14elias
force-pushed
the
feat/target-add-completion
branch
2 times, most recently
from
October 2, 2026 17:18
fbaa255 to
67a2629
Compare
rami3l
approved these changes
Oct 5, 2026
Member
There was a problem hiding this comment.
LGTM modulo the existing threads, thanks!
Waiting for @djc to confirm that all his concerns have been resolved.
djc
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
Member
|
@Kobzol It looks like rust-lang/team#2816 is now blocking any new merges in this repo (because the Also, should |
rami3l
force-pushed
the
feat/target-add-completion
branch
from
October 5, 2026 15:54
67a2629 to
069577b
Compare
This comment has been minimized.
This comment has been minimized.
rami3l
force-pushed
the
feat/target-add-completion
branch
from
October 6, 2026 08:08
069577b to
ee1bf40
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5032
This builds on #5033 and adds dynamic shell completions for target names in
rustup target add.It extends the existing completion_command stuff by attaching an ArgValueCompleter to the target argument, so you can tab-complete available targets for the active toolchain.
Also includes tests that check the completion logic against mocked rustup directories and channel manifests.