Skip to content

refactor(cli): use ValueCandidates for dynamic completion - #5128

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:refactor/cli-dyn-comp-candidates
Oct 6, 2026
Merged

rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:refactor/cli-dyn-comp-candidates

Conversation

@rami3l

@rami3l rami3l commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Follow-up for #5033 and #5110.

As suggested by @FranciscoTGouveia, passing a static list of candidates is enough, as the prefix-based filtering is implied by the clap_complete APIs themselves, which further simplifies the implementation on our end.

The effects of this change are verified since the existing tests related to dynamic completion continue to work without issues.

@rami3l
rami3l marked this pull request as ready for review October 6, 2026 13:49
@rami3l
rami3l requested a review from djc October 6, 2026 13:50
Co-authored-by: Francisco Gouveia <francisco.t.gouveia@tecnico.ulisboa.pt>
@rami3l
rami3l force-pushed the refactor/cli-dyn-comp-candidates branch from 9607fc3 to a6fe514 Compare October 6, 2026 13:50
@rami3l
rami3l added this pull request to the merge queue Oct 6, 2026
Merged via the queue into rust-lang:main with commit 63144ee Oct 6, 2026
29 checks passed
@rami3l
rami3l deleted the refactor/cli-dyn-comp-candidates branch October 6, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants