Repository navigation
refactor(cli): use ValueCandidates for dynamic completion - #5128
Merged
Merged
Conversation
rami3l
marked this pull request as ready for review
October 6, 2026 13:49
Co-authored-by: Francisco Gouveia <francisco.t.gouveia@tecnico.ulisboa.pt>
rami3l
force-pushed
the
refactor/cli-dyn-comp-candidates
branch
from
October 6, 2026 13:50
9607fc3 to
a6fe514
Compare
djc
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #5033 and #5110.
As suggested by @FranciscoTGouveia, passing a static list of candidates is enough, as the prefix-based filtering is implied by the
clap_completeAPIs themselves, which further simplifies the implementation on our end.The effects of this change are verified since the existing tests related to dynamic completion continue to work without issues.