Repository navigation
Fixing https://github.com/simonbs/Runestone/issues/415 - #427
Closed
isontheline wants to merge 1 commit into
Closed
isontheline wants to merge 1 commit into
isontheline wants to merge 1 commit into
Conversation
Author
|
Hey @simonbs 👋 Any news on this? Have a great day ☀️ |
Owner
Hey, I'm sorry I haven't had the time to look into this yet. Things are busy. I'll get to it. Thanks for your patience 🤗 |
Owner
|
Thank you for investigating this crash and putting together a fix, and for your patience! The issue reported in #415 has now been addressed by the merged PR #441, which prepares line fragments before tokenizer boundary queries and adds regression coverage for the synchronous selection callback. I'm closing this PR as superseded by that fix. Thanks again for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @simonbs 👋
Here is my fix proposal about #415 issue.
Have a great day ☀️