Repository navigation
Prepare line fragments before tokenizer boundary queries - #441
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacing text can synchronously trigger UIKit line-boundary queries from selectionDidChange before the rebuilt line has been laid out. Prepare fragments through the queried location before looking them up.
Fixes #415.
Existing PR #427 targets the same underlying problem. This alternative prepares unconditionally, covering both not-yet-typeset lines and previously finished typesetters invalidated by edits, and adds a regression for the reported synchronous callback. The broader movement changes in #427 are not required for that stack trace.
Validation: all 26 tokenizer tests passed on iOS 27.2; SwiftLint passed changed files.