Repository navigation
Require canonical storage width for decimal arrays - #11571
connortsui20 wants to merge 1 commit into
Conversation
b9342a4 to
a0a4cb3
Compare
a0a4cb3 to
9363839
Compare
There was a problem hiding this comment.
This change means that this will no longer build 2 versions of each of the decimal fixtures.
9363839 to
65d506c
Compare
Merging this PR will degrade performance by 9.58%2 warnings
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
65d506c to
6101c3f
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
ac9430c to
87b5498
Compare
A decimal dtype can currently have six canonical representations because a caller can choose the width of its values buffer. The precision now determines that width. Typed constructors report a mismatch, and builders and iterator constructors convert their input at construction. A narrow physical representation uses a
Widenover a narrower decimal child.DecimalBuilderconstructors lose their width parameter. The decimal reader still accepts older storage widths, including narrow nodes emitted by the current writer.Stacked on #11574