Skip to content

Require canonical storage width for decimal arrays - #11571

Open
connortsui20 wants to merge 1 commit into
developfrom
ct/decimal-canonical-width
Open

connortsui20 wants to merge 1 commit into
developfrom
ct/decimal-canonical-width

Conversation

@connortsui20

@connortsui20 connortsui20 commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

A decimal dtype can currently have six canonical representations because a caller can choose the width of its values buffer. The precision now determines that width. Typed constructors report a mismatch, and builders and iterator constructors convert their input at construction. A narrow physical representation uses a Widen over a narrower decimal child.

DecimalBuilder constructors lose their width parameter. The decimal reader still accepts older storage widths, including narrow nodes emitted by the current writer.

Stacked on #11574

@connortsui20 connortsui20 added the changelog/break A breaking API change label Nov 17, 2026
Base automatically changed from ct/dbp-gpu-canonical-width to develop November 17, 2026 20:59
@connortsui20
connortsui20 force-pushed the ct/decimal-canonical-width branch 2 times, most recently from b9342a4 to a0a4cb3 Compare November 17, 2026 21:06
@connortsui20
connortsui20 changed the base branch from develop to ct/unsafe-array-data-mut November 17, 2026 21:07
@connortsui20
connortsui20 force-pushed the ct/decimal-canonical-width branch from a0a4cb3 to 9363839 Compare November 17, 2026 21:07
@connortsui20
connortsui20 marked this pull request as ready for review November 17, 2026 21:22

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change means that this will no longer build 2 versions of each of the decimal fixtures.

@connortsui20
connortsui20 force-pushed the ct/decimal-canonical-width branch from 9363839 to 65d506c Compare November 17, 2026 21:38
@codspeed

codspeed Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.58%

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚡ 2 improved benchmarks
❌ 8 regressed benchmarks
✅ 2012 untouched benchmarks
⏩ 6 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
❌ Walltime compare_u8_neon 1.7 µs 2.2 µs -24.71%
❌ Walltime compare_int_constant_neon 3.2 µs 3.9 µs -17.16%
❌ Walltime compare_f32_neon 4.2 µs 5 µs -15.16%
❌ Walltime compare_int_nullable_neon 4.4 µs 5.2 µs -14.89%
❌ Walltime compare_u64_neon 4 µs 4.6 µs -13.87%
❌ Walltime compare_int_eq_neon 3.9 µs 4.5 µs -13.32%
❌ Walltime compare_int_neon 3.9 µs 4.4 µs -11.53%
❌ Walltime compare_float_neon 6 µs 6.8 µs -11.43%
⚡ CPU Simulation ArrowExportVTable_execute_arrow 202 µs 160.4 µs +25.93%
⚡ CPU Simulation decode_u16[(1, 0.0)] 589.7 µs 535.7 µs +10.07%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ct/decimal-canonical-width (87b5498) with develop (3ebf68d)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Base automatically changed from ct/unsafe-array-data-mut to develop November 17, 2026 21:55
@connortsui20
connortsui20 force-pushed the ct/decimal-canonical-width branch from 65d506c to 6101c3f Compare November 17, 2026 21:55
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
@connortsui20
connortsui20 force-pushed the ct/decimal-canonical-width branch from ac9430c to 87b5498 Compare November 17, 2026 22:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/break A breaking API change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant