Repository navigation
Remove the public Array::data_mut accessor - #11574
Merged
Merged
Conversation
This was referenced Nov 17, 2026
connortsui20
force-pushed
the
ct/unsafe-array-data-mut
branch
from
November 17, 2026 21:07
6dbfeb3 to
fe69bae
Compare
Member
Author
|
We can also just remove this? It doesn't seem like anyone uses this function |
connortsui20
marked this pull request as ready for review
November 17, 2026 21:27
robert3005
approved these changes
Nov 17, 2026
Contributor
|
It's used in chunked array canonical function, one caller in the codebase - I think there's a better way to express this that would let us remove it. |
Contributor
|
You're correct @connortsui20 delete it |
Contributor
|
I have migrated the users to |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
connortsui20
force-pushed
the
ct/unsafe-array-data-mut
branch
from
November 17, 2026 21:38
fe69bae to
5d85de0
Compare
connortsui20
enabled stacked auto-merge (squash)
November 17, 2026 21:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Array::data_mutlets callers replace the entire encoding payload while the array keeps its original dtype, length, child slots, and cached statistics. For example, replacing the payload with a shorter buffer leaves the array reporting its original length.#7677 added the method to advance the chunked builder's cursor in place. #8967 moved that caller to the crate-private
with_data_muthelper. The public method is now unused in the workspace and is removed.