Skip to content

follow-up from #163: items left open by the #161 and #154 test PR #167

Open

Description

@pahud

Open LOW items that #163 (test-only) left open because they need production changes or a maintainer decision. They come from #161 and #154.

  • Sources/ stdio client, ToolListPagination.collect: it measures its deadline with Date(), a wall clock that can jump. Why it matters: a clock change can shorten or extend the listing budget. Fix: use a monotonic clock (ContinuousClock or DispatchTime).
  • Sources/ HTTP client, listTools: it calls collect(deadline: .infinity). Why it matters: the intent (no per-call deadline, the caller owns the budget) is hidden in a sentinel value. Fix: add a deadline-less overload.
  • Sources/ isServerProtocolError branch: it only makes intent explicit, and the managed protocol-error test pins existing behavior. Observation only; revisit if the branch gains logic.
  • InstanceMCPCore, BrowserToolsController: its whole API is public. Why it matters: it widens the module surface for a type that only the app uses. Fix: decide the intended access level and narrow it.
  • Issue tracking: an earlier PR said "closes Browser tools wizard: tests do not cover the production wiring (follow-up from PR #127 review) #129" but only partly addressed it. Maintainer decision: reopen or split the remainder into a new issue.

Source: the "left open" rows in the #163 description.

Activity

  1. added
    p3Priority 3: RFC, roadmap, nice-to-have or deferred
    on Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    p3Priority 3: RFC, roadmap, nice-to-have or deferred

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions